rust-review
npx machina-cli add skill athola/claude-night-market/rust-review --openclawTable of Contents
- Quick Start
- When to Use
- Required TodoWrite Items
- Progressive Loading
- Core Workflow
- Rust Quality Checklist
- Safety
- Correctness
- Performance
- Idioms
- Output Format
- Summary
- Ownership Analysis
- Error Handling
- Concurrency
- Unsafe Audit
- [U1] file:line
- Dependencies
- Recommendation
- Exit Criteria
Rust Review Workflow
Expert-level Rust code audits with focus on safety, correctness, and idiomatic patterns.
Quick Start
/rust-review
Verification: Run the command with --help flag to verify availability.
When To Use
- Reviewing Rust code changes
- Auditing unsafe blocks
- Analyzing concurrency patterns
- Dependency security review
- Performance optimization review
When NOT To Use
- General code review without Rust - use unified-review
- Performance profiling - use parseltongue:python-performance pattern
Required TodoWrite Items
rust-review:ownership-analysisrust-review:error-handlingrust-review:concurrencyrust-review:unsafe-auditrust-review:cargo-depsrust-review:evidence-log
Progressive Loading
Load modules as needed based on review scope:
Quick Review (ownership + errors):
- See
modules/ownership-analysis.mdfor borrowing and lifetime analysis - See
modules/error-handling.mdfor Result/Option patterns
Concurrency Focus:
- See
modules/concurrency-patterns.mdfor async and sync primitives
Safety Audit:
- See
modules/unsafe-audit.mdfor unsafe block documentation
Dependency Review:
- See
modules/cargo-dependencies.mdfor vulnerability scanning
Core Workflow
- Ownership Analysis: Check borrowing, lifetimes, clone patterns
- Error Handling: Verify Result/Option usage, propagation
- Concurrency: Review async patterns, sync primitives
- Unsafe Audit: Document invariants, FFI contracts
- Dependencies: Scan for vulnerabilities, updates
- Evidence Log: Record commands and findings
Rust Quality Checklist
Safety
- All unsafe blocks documented with SAFETY comments
- FFI boundaries properly wrapped
- Memory safety invariants maintained
Correctness
- Error handling complete
- Concurrency patterns sound
- Tests cover critical paths
Performance
- No unnecessary allocations
- Borrowing preferred over cloning
- Async properly non-blocking
Idioms
- Standard traits implemented
- Error types well-designed
- Documentation complete
Output Format
## Summary
Rust audit findings
## Ownership Analysis
[borrowing and lifetime issues]
## Error Handling
[error patterns and issues]
## Concurrency
[async and sync patterns]
## Unsafe Audit
### [U1] file:line
- Invariants: [documented]
- Risk: [assessment]
- Recommendation: [action]
## Dependencies
[cargo audit results]
## Recommendation
Approve / Approve with actions / Block
Verification: Run the command with --help flag to verify availability.
Exit Criteria
- All unsafe blocks audited
- Concurrency patterns verified
- Dependencies scanned
- Evidence logged
- Action items assigned
Troubleshooting
Common Issues
Command not found Ensure all dependencies are installed and in PATH
Permission errors Check file permissions and run with appropriate privileges
Unexpected behavior
Enable verbose logging with --verbose flag
Source
git clone https://github.com/athola/claude-night-market/blob/master/plugins/pensive/skills/rust-review/SKILL.mdView on GitHub Overview
Rust Review provides expert-level Rust audits focused on safety, correctness, and idiomatic patterns. It analyzes ownership, unsafe blocks, and Cargo dependencies to identify risks and ensure robust, maintainable code.
How This Skill Works
The skill guides a structured workflow: perform ownership analysis to inspect borrowing and lifetimes, verify error propagation with Result/Option, and review concurrency patterns. It then audits unsafe blocks with SAFETY invariants, documents FFI contracts, and scans Cargo dependencies for vulnerabilities and updates, recording findings in an evidence log.
When to Use It
- Reviewing Rust code changes for safety and correctness
- Auditing unsafe blocks and FFI boundaries
- Analyzing concurrency patterns (async and sync) for correctness
- Reviewing Cargo dependencies for vulnerabilities and updates
- Performance-focused review addressing allocations and borrowing efficiency
Quick Start
- Step 1: Run /rust-review
- Step 2: Verify availability with --help
- Step 3: Start with quick review focusing on ownership and errors, then expand to concurrency and unsafe-audit as needed
Best Practices
- Start with Ownership Analysis focusing on borrowing, lifetimes, and clone patterns
- Document all unsafe blocks with SAFETY comments and check FFI boundaries
- Validate Result/Option usage and proper error propagation
- Review concurrency patterns (async and sync primitives) for correctness
- Run dependency security review and vulnerability scanning on Cargo.toml
Example Use Cases
- Auditing a module with unsafe blocks to ensure SAFETY comments are present and invariants are documented
- Tracing ownership transfers across function boundaries to prevent unintended moves or drops
- Assessing Arc<Mutex<T>> usage to identify potential deadlocks or contention hotspots
- Scanning Cargo.lock for vulnerable crate versions and proposing safe version bumps
- Ensuring error propagation paths are complete and well-typed across modules